Change nori_number Token Filter Korean numeral format in ES document #118232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
elasticsearchmachine
added
needs:triage
getsolaris
changed the title
nori_number Token Filter Korean numeral format in ES document
getsolaris
changed the title
nori_number Token Filter Korean numeral format in ES document
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
removed
the
needs:triage
|
Pinging @elastic/es-docs (Team:Docs) |
|
@elasticmachine this this please |
|
@elasticmachine test this please |
john-wagster
added
auto-backport
|
This looks good; kicking off tests to double check, but don't expect failures and then will merge. Thanks so much for catching that @getsolaris! |
This was referenced Dec 11, 2024
john-wagster
pushed a commit
to john-wagster/elasticsearch
that referenced
this pull request
Dec 11, 2024
john-wagster
pushed a commit
to john-wagster/elasticsearch
that referenced
this pull request
Dec 11, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: getsolaris <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: getsolaris <[email protected]>
|
Thank you @john-wagster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current format represents the number 1000006005001 as "조육백만오천일". However, the proper Korean numeral expression for this value should include "일" for clarity when dealing with values in the "조" (trillion) range. The correct representation is "일조육백만오천일".
Including "일" before "조" aligns with the standard way of reading Korean numerals and avoids potential ambiguity. This change improves the document's accuracy and readability for users who rely on these numeral representations.